convert : more detailed convert lora usage docs #10065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
reviewed
Oct 28, 2024
richdougherty
force-pushed
the
convert-lora-usage
branch
from
5811cbc to
3eb73ff
Compare
ngxson
approved these changes
Oct 29, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few more details to the LoRA conversion script about the files that are needed in each directory. Having these details will hopefully help people with the workflow required to use LoRA adapters in llama.cpp since @ngxson's recent LoRA refactor in #8332.
(Note that I'm new to this, so happy to fix any mistakes or add wording - or, if this is all assumed knowledge, to close the PR.)